Mercurial > hg > index.cgi
view test/runtests @ 577:e49d24f4a9a5
Correct bug in the object file output code leading to stack corruption
It turns out leaving a pointer to a stack allocated temporary in a
persistent data structure is not conducive to correct program operation.
Undo the export check setup in the object file output sequence so a
pointer to stack allocated memory is not left hanging when the function
returns. This seems to correct at least one mysterious crash bug, and
possibly others.
Thanks to Boisy Pitre for reporting the crash bug that led to this
discovery, as well as a previous crash bug that likely has the same
root cause.
Additional thanks to Ciaran Anscomb whose debugger wielding wizardry
revealed the exact location of this particular bit of unbrilliance.
author | William Astle <lost@l-w.ca> |
---|---|
date | Sat, 03 Aug 2024 14:30:06 -0600 |
parents | 3cd8aa013b88 |
children |
line wrap: on
line source
#!/usr/bin/env perl # # This program will execute all programs in the "tests" directory. Each # program is expected to produce output as follows on stdout: # # each line begins with a test name followed by whitespace followed by # PASS, FAIL, or SKIP. # # stderr is not redirected during testing. Any test that might spam stderr # is encouraged to redirect it somewhere useful. # # After each test script exits, a report indicating number passed, failed, # and skipped is presented, or if the script failed to run. # # Once all tests have been run, a report showing the grand total number of # tests performed, passed, failed, and skipped. # # Each test can be in any programming language that is appropriate for # the task. # # Each test can assume the current directory is the root of the source tree. use File::Basename; $testdir = dirname($0) . '/tests'; opendir DH, $testdir; while ($fe = readdir DH) { next if ($fe =~ /^\./); next if ($fe =~ /~$/); $fn = $testdir . '/' . $fe; open P,"$fn|"; while (<P>) { chomp; ($tn, $ts) = split /\s+/; $testresults{$fe}{$tn} = $ts; if ($ts eq 'PASS') { $testspassed += 1; $testresults{$fe}{'..passed'} += 1; } elsif ($ts eq 'FAIL') { $testsfailed += 1; $testresults{$fe}{'..failed'} =+ 1; } elsif ($ts eq 'SKIP') { $testsskipped += 1; $testresults{$fe}{'..skipped'} += 1; } else { $testsunknown += 1; $testresults{$fe}{'..unknown'} += 1; } $teststotal += 1; $testresults{$fe}{'..total'} += 1; } close P; $fdn = $fe; $fdn =~ s/\..+?$//; $rline = sprintf("%-25.25s: %d/%d (%d skipped, %d unknown, %d failed)", $fdn, $testresults{$fe}{'..passed'}, $testresults{$fe}{'..total'}, $testresults{$fe}{'..skipped'}, $testresults{$fe}{'..unknown'}, $testresults{$fe}{'..failed'}); print "$rline\n"; } closedir DH; print sprintf("\n===================\nTotal: %d/%d (%d skipped, %d unknown, %d failed)\n", $testspassed, $teststotal, $testsskipped, $testsunknown, $testsfailed); if ($testspassed < $teststotal) { print "\nThe following tests either failed or were otherwise dubious:\n"; foreach $i (keys %testresults) { $fdn = $i; $fdn =~ s/\..+?$//; foreach $j (keys %{ $testresults{$i} }) { next if $j =~ /^\./; if ($testresults{$i}{$j} ne 'PASS') { print "$fdn/$j: $testresults{$i}{$j}\n"; } } } exit 1; } exit 0;