Mercurial > hg > index.cgi

changeset 239:8beb109dfd69

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fix hang on undefined symbol in rmb under pragma undefextern Problem in the pass4.c implementation led to an infinite loop if any instructions failed to resolve. Instead, if a pass through the loop fails to resolve anything, bail out since it's clearly pointless to continue trying.
author William Astle <lost@l-w.ca>
date Tue, 14 Aug 2012 21:06:52 -0600
parents 91f91557dc9e
children 41d64951eb32
files lwasm/pass4.c
diffstat 1 files changed, 4 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/lwasm/pass4.c	Mon Aug 13 17:22:13 2012 -0600
+++ b/lwasm/pass4.c	Tue Aug 14 21:06:52 2012 -0600
@@ -40,6 +40,7 @@
 	int cnt;
 	line_t *cl, *sl;
 	struct line_expr_s *le;
+	int trycount = 0;
 
 	// first, count the number of unresolved instructions
 	for (cnt = 0, cl = as -> line_head; cl; cl = cl -> next)
@@ -51,6 +52,7 @@
 	sl = as -> line_head;
 	while (cnt > 0)
 	{
+		trycount = cnt;
 		debug_message(as, 60, "%d unresolved instructions", cnt);
 
 		// find an unresolved instruction
@@ -142,6 +144,8 @@
 			if (as -> errorcount > 0)
 				return;
 		} while (rc > 0);
+		if (trycount == cnt)
+			break;
 	}
 }